Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: Prevent oclif from loading ts-node and typescript #5047

Merged
merged 1 commit into from
Dec 29, 2022

Conversation

netroy
Copy link
Member

@netroy netroy commented Dec 28, 2022

This reduces the startup memory spike from 200MB to 170MB

@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Dec 28, 2022
Copy link
Contributor

@ivov ivov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested a handful of commands and all still working: start, export:workflow, list:workflow, execute, user-management:reset

Tested a container of this branch and showing 16 MB less memory usage than master.

Related: oclif/oclif#333

@netroy netroy merged commit 1a6f7a1 into master Dec 29, 2022
@netroy netroy deleted the oclif-memory-usage branch December 29, 2022 11:23
@n8n-assistant n8n-assistant bot added the Upcoming Release Will be part of the upcoming release label Dec 29, 2022
MiloradFilipovic added a commit that referenced this pull request Dec 29, 2022
* master:
  ci: Fix linting on builds (no-changelog) (#5062)
  refactor: Lint for no interpolation in regular string (#5060) (no-changelog)
  ci: Fix lint for build (no-changelog) (#5059)
  perf: Prevent oclif from loading ts-node and typescript (#5047) (no-changelog)
  fix(editor): Make node title non-editable in executions view (#5046)
  refactor: Lint for no unneeded backticks (#5057) (no-changelog)
  fix(core): Fix full manual execution for error trigger as starter of 2+ node workflow (#5055)
  fix(editor): Support tabbing away from inline expression editor (#5056)
  refactor(editor): Usage and plans page on Desktop (#5051)
  📚 Update CHANGELOG.md and main package.json to 0.209.4
  🔖 Release [email protected]
  ⬆️ Set [email protected] on n8n
  🔖 Release [email protected]
  fix(editor): Usage and plans page on Desktop (#5045)
  feat(editor): Switch to expression on `=` input (#5044)
  fix(editor): Fix trigger node type identification on add to canvas (#5043)
@janober
Copy link
Member

janober commented Jan 5, 2023

Got released with [email protected]

@janober janober removed the Upcoming Release Will be part of the upcoming release label Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants